Klarna fix - Handling SDK action as standalone component #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeiroguilherme
requested review from
pabloai,
sponglord,
m1aw and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 8dd954a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +92 B (+0.01%) Total Size: 770 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
sponglord
approved these changes
Jan 6, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before v6.6.0, Klarna component was handling the action through 2 different ways:
handleActionwas directly calling KlarnaupdateWithActionpassing the action and therefore triggering the re-render of the Component.handleActionwas creating a new Klarna component and passing the action as props (as it can be seen here)With the changes introduced by v6.6.0, the
KlarnaContainerstopped receiving theactionasprops(which caused the standalone Component integration to break). The action started being supported by setting it explicitly by calling the setAction from the parent, and props weren't used anymore.To fix this issue and keep supporting the standalone integration, the following change was added:
handleActiononKlarnaelement, overriding the default one fromUIElement. ItshandleActionwill handle in case the widget needs to be loaded, otherwise it will fallback to the UIElementhandleAction.handleActionfrom UIElement will handle itactionfor the Klarna component as opposed to how it was beforeTests