Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate barCode URLs against the new endpoint #2936

Merged
merged 2 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/clever-pants-cover.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@adyen/adyen-web': patch
---

A new barcode endpoint has been created on the backend. This PR generates barCode URLs against that endpoint.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const BoletoVoucherResult = props => {
const getImage = useImage();
const { reference, expiresAt, downloadUrl } = props;
const barcodeReference = reference.replace(/[^\d]/g, '').replace(/^(\d{4})(\d{5})\d{1}(\d{10})\d{1}(\d{10})\d{1}(\d{15})$/, '$1$5$2$3$4');
const barcodeUrl = `${loadingContext}barcode.shtml?data=${barcodeReference}&barcodeType=BT_Int2of5A&fileType=png`;
const barcodeUrl = `${loadingContext}utility/v1/barcode.png?data=${barcodeReference}&type=itf&clientKey=${props.clientKey}`;

const paymentMethodType = 'boletobancario'; // overwrite the bank specific type of boleto, e.g. 'boletobancario_santander', to a more generic form

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ const OxxoVoucherResult = (props: OxxoVoucherResultProps) => {
const getImage = useImage();
const { alternativeReference, reference, expiresAt, merchantReference, downloadUrl } = props;

const barcodeUrl = `${loadingContext}barcode.shtml?data=${reference}&barcodeType=BT_Code128C&fileType=png`;
const barcodeUrl = `${loadingContext}utility/v1/barcode.png?data=${reference}&type=code128c&clientKey=${props.clientKey}`;

const voucherDetails: VoucherDetail[] = [
...(expiresAt
? [
Expand Down
1 change: 1 addition & 0 deletions packages/lib/src/components/Oxxo/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@ export interface OxxoVoucherResultProps {
downloadUrl?: string;
ref?: any;
onActionHandled?: (rtnObj: ActionHandledReturnObject) => void;
clientKey?: string;
}
8 changes: 6 additions & 2 deletions packages/lib/src/components/internal/QRLoader/QRLoader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import useAutoFocus from '../../../utils/useAutoFocus';
import { ANALYTICS_DOWNLOAD_STR, ANALYTICS_QR_CODE_DOWNLOAD } from '../../../core/Analytics/constants';
import { PREFIX } from '../Icon/constants';

const QRCODE_URL = 'barcode.shtml?barcodeType=qrCode&fileType=png&data=';
const QRCODE_URL = 'utility/v1/barcode.png?type=qrCode&data=';

class QRLoader extends Component<QRLoaderProps, QRLoaderState> {
private timeoutId;
Expand Down Expand Up @@ -153,7 +153,11 @@ class QRLoader extends Component<QRLoaderProps, QRLoaderState> {
render({ amount, url, brandLogo, brandName, countdownTime, type, onActionHandled }: QRLoaderProps, { expired, completed, loading }) {
const { i18n, loadingContext } = useCoreContext();
const getImage = useImage();
const qrCodeImage = this.props.qrCodeData ? `${loadingContext}${QRCODE_URL}${this.props.qrCodeData}` : this.props.qrCodeImage;

const qrCodeImage = this.props.qrCodeData
? `${loadingContext}${QRCODE_URL}${this.props.qrCodeData}&clientKey=${this.props.clientKey}`
: this.props.qrCodeImage;

const finalState = (image, message) => {
const status = i18n.get(message);
useA11yReporter(status);
Expand Down
6 changes: 2 additions & 4 deletions packages/lib/src/core/Analytics/Analytics.utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -685,8 +685,7 @@ describe('Testing creating a configData object for the Card components', () => {
/**
* 31. showPayButton
*/
// TODO - skip until endpoint can accept more entries in the configData object (current limit: 32);
describe.skip('Testing showPayButton', () => {
describe('Testing showPayButton', () => {
const ANALYTICS_DATA_PROP = 'showPayButton';
const CARD_CONFIG_PROP = ANALYTICS_DATA_PROP;

Expand All @@ -709,8 +708,7 @@ describe('Testing creating a configData object for the Card components', () => {
/**
* 32. socialSecurityNumberMode
*/
// TODO - skip until endpoint can accept more entries in the configData object (current limit: 32);
describe.skip('Testing socialSecurityNumberMode', () => {
describe('Testing socialSecurityNumberMode', () => {
const ANALYTICS_DATA_PROP = 'socialSecurityNumberMode';

const configuration: any = { socialSecurityNumberMode: 'show' };
Expand Down
Loading