Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click to Pay - 3rd party cookies #2409

Merged
merged 16 commits into from
Dec 4, 2023

Conversation

ribeiroguilherme
Copy link
Contributor

@ribeiroguilherme ribeiroguilherme commented Nov 6, 2023

Summary

Enabling MC/Visa to drop cookies if the shopper gives consent.

Highlights:

  • Created self-contained Click to Pay Consent checkbox Component, which dictates if the shopper gave consent or not to store the cookies. Default value is always false
  • When consent is given, during the Checkout process with MC/Visa, we pass a new parameter called complianceSettings
  • Replaced login InputText with proper InputEmail component

Tested scenarios

  • Added unit tests covering the checkbox state ; checkout payload; toggling checkbox values and propagating it to the click to pay service;
  • Feature also got validated by Visa

Copy link

changeset-bot bot commented Nov 6, 2023

🦋 Changeset detected

Latest commit: da84526

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 6, 2023

Size Change: +5.58 kB (+1%)

Total Size: 1.1 MB

Filename Size Change
packages/lib/dist/adyen.js 291 kB +1.39 kB (0%)
packages/lib/dist/cjs/index.js 252 kB +1.23 kB (0%)
packages/lib/dist/es.modern/ar.js 6.72 kB +55 B (+1%)
packages/lib/dist/es.modern/cs-CZ.js 5.98 kB +42 B (+1%)
packages/lib/dist/es.modern/da-DK.js 5.41 kB +23 B (0%)
packages/lib/dist/es.modern/de-DE.js 5.86 kB +32 B (+1%)
packages/lib/dist/es.modern/el-GR.js 7.64 kB +28 B (0%)
packages/lib/dist/es.modern/es-ES.js 5.51 kB +29 B (+1%)
packages/lib/dist/es.modern/fi-FI.js 5.52 kB +33 B (+1%)
packages/lib/dist/es.modern/fr-FR.js 5.71 kB +31 B (+1%)
packages/lib/dist/es.modern/hr-HR.js 5.76 kB +48 B (+1%)
packages/lib/dist/es.modern/hu-HU.js 6.02 kB +38 B (+1%)
packages/lib/dist/es.modern/index.js 120 kB +461 B (0%)
packages/lib/dist/es.modern/it-IT.js 5.59 kB +41 B (+1%)
packages/lib/dist/es.modern/ja-JP.js 6.47 kB +39 B (+1%)
packages/lib/dist/es.modern/ko-KR.js 6.08 kB +52 B (+1%)
packages/lib/dist/es.modern/nl-NL.js 5.54 kB +34 B (+1%)
packages/lib/dist/es.modern/no-NO.js 5.38 kB +20 B (0%)
packages/lib/dist/es.modern/pl-PL.js 6.06 kB +55 B (+1%)
packages/lib/dist/es.modern/pt-BR.js 5.57 kB +33 B (+1%)
packages/lib/dist/es.modern/pt-PT.js 5.69 kB +27 B (0%)
packages/lib/dist/es.modern/ro-RO.js 5.83 kB +39 B (+1%)
packages/lib/dist/es.modern/ru-RU.js 7.13 kB +42 B (+1%)
packages/lib/dist/es.modern/sk-SK.js 6.13 kB +36 B (+1%)
packages/lib/dist/es.modern/sl-SI.js 5.69 kB +35 B (+1%)
packages/lib/dist/es.modern/sv-SE.js 5.4 kB +29 B (+1%)
packages/lib/dist/es.modern/zh-CN.js 5.9 kB +38 B (+1%)
packages/lib/dist/es.modern/zh-TW.js 6.02 kB +32 B (+1%)
packages/lib/dist/es/ar.js 6.72 kB +55 B (+1%)
packages/lib/dist/es/cs-CZ.js 5.98 kB +42 B (+1%)
packages/lib/dist/es/da-DK.js 5.41 kB +23 B (0%)
packages/lib/dist/es/de-DE.js 5.86 kB +32 B (+1%)
packages/lib/dist/es/el-GR.js 7.64 kB +28 B (0%)
packages/lib/dist/es/es-ES.js 5.51 kB +29 B (+1%)
packages/lib/dist/es/fi-FI.js 5.52 kB +33 B (+1%)
packages/lib/dist/es/fr-FR.js 5.71 kB +31 B (+1%)
packages/lib/dist/es/hr-HR.js 5.76 kB +48 B (+1%)
packages/lib/dist/es/hu-HU.js 6.02 kB +38 B (+1%)
packages/lib/dist/es/index.js 140 kB +686 B (0%)
packages/lib/dist/es/it-IT.js 5.59 kB +41 B (+1%)
packages/lib/dist/es/ja-JP.js 6.47 kB +39 B (+1%)
packages/lib/dist/es/ko-KR.js 6.08 kB +52 B (+1%)
packages/lib/dist/es/nl-NL.js 5.54 kB +34 B (+1%)
packages/lib/dist/es/no-NO.js 5.38 kB +20 B (0%)
packages/lib/dist/es/pl-PL.js 6.06 kB +55 B (+1%)
packages/lib/dist/es/pt-BR.js 5.57 kB +33 B (+1%)
packages/lib/dist/es/pt-PT.js 5.69 kB +27 B (0%)
packages/lib/dist/es/ro-RO.js 5.83 kB +39 B (+1%)
packages/lib/dist/es/ru-RU.js 7.13 kB +42 B (+1%)
packages/lib/dist/es/sk-SK.js 6.13 kB +36 B (+1%)
packages/lib/dist/es/sl-SI.js 5.69 kB +35 B (+1%)
packages/lib/dist/es/sv-SE.js 5.4 kB +29 B (+1%)
packages/lib/dist/es/zh-CN.js 5.9 kB +38 B (+1%)
packages/lib/dist/es/zh-TW.js 6.02 kB +32 B (+1%)

compressed-size-action

@ribeiroguilherme ribeiroguilherme changed the title [WIP] Click to Pay - 3rd party cookies [waiting for translations] Click to Pay - 3rd party cookies Nov 13, 2023
@ribeiroguilherme ribeiroguilherme marked this pull request as ready for review November 13, 2023 13:50
@ribeiroguilherme ribeiroguilherme changed the title [waiting for translations] Click to Pay - 3rd party cookies Click to Pay - 3rd party cookies Nov 15, 2023
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

47.7% 47.7% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ribeiroguilherme ribeiroguilherme merged commit fcf40a1 into main Dec 4, 2023
9 of 10 checks passed
@ribeiroguilherme ribeiroguilherme deleted the feature/click-to-pay-storing-cookies branch December 4, 2023 08:38
@github-actions github-actions bot mentioned this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants