feat: new design for the dropin #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c077edd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +4.59 kB (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
longyulongyu
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
ribeiroguilherme
as code owners
… payments and stored payments
longyulongyu
force-pushed
the
dropin-new-design
branch
from
fe71a07 to
7cf54e0
Compare
size-limit report 📦
|
# Conflicts: # packages/lib/src/components/Dropin/components/PaymentMethod/InstantPaymentMethods.tsx
|
Kudos, SonarCloud Quality Gate passed! |
|
It's not entirely clear to me which variables that I, as a merchant, should be overwriting... |
sponglord
approved these changes
Nov 27, 2023
I agree, I will work on a doc to explain the purpose of each component level variable, or perhaps an interactive story. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New design for the drop-in component:
Tested scenarios