fix: remove inline style applied to iframe due to CSP #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 68bb6d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -241 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
|
Kudos, SonarCloud Quality Gate passed! |
longyulongyu
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
ribeiroguilherme
as code owners
sponglord
approved these changes
Oct 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This ticket solves the problem when the nonce attribute is set on the
<style>tag, some of the inline styles set to the iframe are blocked.The changes include subtracting those styles in a separate scss file.
Tested scenarios
How to reproduce the issue:
mainbranch, modify the style-loader config in thepackages/playground/config/webpack.dev.js. This step is to allow the webpack dev server to add nonce value to style sheets (playground + adyen-web styles)<head>section in thepackages/playground/src/pages/Dropin/Dropin.htmlRefused to apply inline style because it violates the following Content Security Policy directivefor google paypay.jsandcreateIframe.tsfix-csp-issue-due-to-inline-style, restart the playground, wait for development build.. We shouldn't see browser throwing issues forcreateIframe.tsfile. (Thepay.jsfrom Google pay remains.)<meta>tag, the dropin should render and function correctly.Fixed issue: #2336
Note:
This ticket doesn't solve Google pay when enabling CSP nonce, merchants can follow the Google's CSP advice.