fix: Clear timeouts on SecuredFieldsProvider when unmounting the component #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecuredFieldsProvider uses timeouts to check whether securedfields are loaded properly. Those timeouts are not cleared when the component unmounts which causes issues if said those fields have already been unmounted as this triggers the onError handlers.
kaakock
requested review from
marcperez,
pabloai,
sponglord,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 497f018 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hi! |
|
In which case this is a very timely PR! Thank you :-) |
We need a `.changeset file` to initiate the required actions in our workflow
sponglord
approved these changes
Oct 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SecuredFieldsProvider uses timeouts to check whether SecureFields are loaded properly. Those timeouts are not cleared when the component unmounts which causes issues if the fields have already been unmounted. This triggers the onError handler in cases where it should not.
Tested scenarios
Mounting and almost immediately unmounting adyen drop-in triggers the onError handler.