Add index.php files to directories #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [PrestaShop documentation and the code validator](https://devdocs.prestashop.com/1.7/modules/concepts/composer/#important-notes), having an index.php file in each directory helps with the e-commerce security.
msilvagarcia
requested review from
Aleffio,
cyattilakiss and
rikterbeek
as code owners
cyattilakiss
approved these changes
Jan 7, 2020
|
@msilvagarcia shall we add this as a devDependency in the composer file so it is easily to use for us all ? |
rikterbeek
approved these changes
Jan 7, 2020
|
@rikterbeek We need to figure a way to set the file with our copyright header to do so. The app uses the file index.php that's inside the sources folder in itself, so either fork it with our version of the index.php or add the feature to configure the index.php to copy from. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the PrestaShop Code Validator, having an index.php file in each directory helps with the e-commerce security.
These files were added with the autoindex package.