PW-1762 Redirect shopper to external authorization #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add an exception that is usually logged somewhere * Create a refund model * Simplify unnecessary abstraction * Replace qualifier with an import * Listen to actionOrderSlipAdd hook * Fix notification message * Add a method to get an order by order slips This will be used as the merchant reference in the refund request. When a refund notification arrives, we need to be sure to fetch an order based on this order slip id. * Change reference to ID * Adjust fetching of order object based on order slips * Fix order object fetching * Fix module * Update service/modification/Refund.php Co-Authored-By: Alessio Zampatti <[email protected]> * Remove logging * Extract method for SQL query * Make intentions more explicit * Fix Refund tests * Fix Refund tests * Refactor the Adyen main class * Help @Aleffio Co-Authored-By: Alessio Zampatti <[email protected]>
* Add PHP Code Sniffer * Move configuration around * Clarify PHPCS instruction
# Conflicts: # adyen.php # controllers/admin/AdminAdyenPrestashopCronController.php # controllers/front/Payment.php # controllers/front/ThreeDSProcess.php # controllers/front/Validate3d.php # service/adapter/classes/order/OrderAdapter.php
msilvagarcia
requested review from
Aleffio,
cyattilakiss and
rikterbeek
as code owners
rikterbeek
reviewed
Nov 4, 2019
| $this->context->smarty->assign( | ||
| array( | ||
| 'locale' => $this->helper_data->getLocale($this->context->language), | ||
| // no locale in PrestaShop1.6 only languageCode that is en-en but we need en_EN |
There was a problem hiding this comment.
should we define a default ?
There was a problem hiding this comment.
what do you mean with this?
There was a problem hiding this comment.
You are specifying that for 1.6 the format is incorrect en-en instead of en_EN should we then not prefine it for 1.6 to en_EN or should we make a converter that makes en-en to en_EN ?
There was a problem hiding this comment.
I think we need to do this in the getLocale function in the helper_data, I will create a youtrack ticket for this, so we can discuss
Aleffio
reviewed
Nov 4, 2019
Aleffio
approved these changes
Nov 6, 2019
msilvagarcia
added a commit
that referenced
this pull request
Nov 11, 2019
This commit contains changes from Pull Requests #27 and #35. It also wraps up the development of Local Payment Methods that work with a simple setup, like iDeal, Sofort and Dotpay. Co-Authored-By: Alessio Zampatti <[email protected]> Co-Authored-By: cyattilakiss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.