PW-1556 execute notifications #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notifications - Rename notificationProcessor to notificationReceiver because it handles receiving and saving notifications - Fix for ajaxRender: exit after rendering - Fix for ajaxRender: set this->ajax to true by default - Fix for try catches: if catch triggered, return something ot exit to prevent errors - Create Configuration class for global settings - Fix for link generation: burnt in links are not working since friendly url setting overwrites the default url structure and triggers error when trying to open an 'old' link - add installTab and createCronJobToken to upgrade 1.0.1 - process authorisation notifications - adding a message if processed - expose admin controller for cron jobs to call
cyattilakiss
changed the title
cyattilakiss
commented
Sep 30, 2019
| 'hint' => $this->l('Must correspond to the notification HMAC Key in the Adyen Backoffice under Settings => Notifications => Additional Settings => HMAC Key (HEX Encoded)') | ||
| ), | ||
| array( | ||
| 'type' => 'password', | ||
| 'label' => $this->l('Secure token for cron job'), |
There was a problem hiding this comment.
for the other options discuss wioth grant if we should remove the required label
- Don't use Tools::encrypt but use our helpers encrypt function - getPageLink correct usage: pass the get parameters as a parameter for the function - Move Configuration under servive - Use $this->ajax only in version 1.6 - Performance optimisations - Skip report notifications - do not save them in the database - Show adyen notification process url in the settings
rikterbeek
approved these changes
Oct 1, 2019
Aleffio
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notifications
handles receiving and saving notifications
prevent errors
friendly url setting overwrites the default url structure and triggers
error when trying to open an 'old' link