Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW-2385] Add check notification event code supports hmac. #197

Merged
merged 7 commits into from
May 22, 2020

Conversation

AlexandrosMor
Copy link
Contributor

Description
Added the check isHmacSupportedEventCode to the library. This check returns true if the notification event code supports hmac calculation.

Tested scenarios
Add Unit test to test an existing event code in the list

src/Adyen/Util/HmacSignature.php Outdated Show resolved Hide resolved
src/Adyen/Util/HmacSignature.php Outdated Show resolved Hide resolved
@AlexandrosMor AlexandrosMor changed the title [PW-2385] Add the check notification event code supports hmac. [PW-2385] Add check notification event code supports hmac. May 22, 2020
@cyattilakiss
Copy link
Contributor

@AlexandrosMor Please see the code smell from sonar cloud!

@@ -127,4 +127,22 @@ public function testHmacSignatureEscaping()
$this->fail('Unexpected exception');
}
}

public function testisHmacSupportedEventCode()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor

Suggested change
public function testisHmacSupportedEventCode()
public function testIsHmacSupportedEventCode()

acampos1916
acampos1916 previously approved these changes May 22, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AlexandrosMor AlexandrosMor merged commit 54bfbfb into develop May 22, 2020
@AlexandrosMor AlexandrosMor deleted the PW-2385_HMAC_validation branch May 22, 2020 13:49
@cyattilakiss cyattilakiss mentioned this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants