Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Local Unencrypted TAPI #1244

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Conversation

jillingk
Copy link
Contributor

@jillingk jillingk commented Sep 1, 2023

Description
This pr adds support for the local terminal api without encryption. This is tested with a test terminal.

@jillingk jillingk requested a review from a team as a code owner September 1, 2023 12:56
@jillingk jillingk added the Feature New feature or request label Sep 1, 2023
};
if (terminalCertificatePath == "unencrypted"){
this.agentOptions = {
rejectUnauthorized: false

Check failure

Code scanning / CodeQL

Disabling certificate validation

Disabling certificate validation is strongly discouraged.
wboereboom
wboereboom previously approved these changes Sep 1, 2023
README.md Outdated Show resolved Hide resolved
Co-authored-by: Michael Paul <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jillingk jillingk requested review from wboereboom and a team September 4, 2023 05:33
@wboereboom wboereboom merged commit e23bd0b into develop Sep 4, 2023
@wboereboom wboereboom deleted the unencrypted-local-tapi branch September 4, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants