Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename release.js.1 to release.js #1225

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Rename release.js.1 to release.js #1225

merged 4 commits into from
Aug 9, 2023

Conversation

wboereboom
Copy link
Contributor

Description
fix script name

@wboereboom wboereboom requested a review from a team as a code owner August 8, 2023 08:46
AlexandrosMor
AlexandrosMor previously approved these changes Aug 8, 2023
View reviewed changes
Aleffio
Aleffio previously approved these changes Aug 8, 2023
View reviewed changes
michaelpaul
michaelpaul suggested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@michaelpaul michaelpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also fix the workflow step:

adyen-node-api-library/.github/workflows/lib-release.yml

Line 26 in b4774d1

wget https://raw.githubusercontent.com/Adyen/adyen-node-api-library/develop/.github/scripts/release.js -P ./.github/scripts

We can add a check there to only download the file if one does not exist yet.

@wboereboom
Update lib-release.yml
5a18bb4 
Add condition to verify release script does not already exist
@wboereboom wboereboom requested a review from michaelpaul August 8, 2023 11:52
@wboereboom wboereboom dismissed stale reviews from Aleffio and AlexandrosMor via 5a18bb4 August 8, 2023 11:52
michaelpaul
michaelpaul approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@michaelpaul michaelpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a solution that doesn't require another third-party action.

@michaelpaul michaelpaul enabled auto-merge (squash) August 8, 2023 15:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@michaelpaul michaelpaul merged commit c0317c6 into develop Aug 9, 2023
@michaelpaul michaelpaul deleted the fix-script-name branch August 9, 2023 08:27
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillingk jillingk jillingk approved these changes

@michaelpaul michaelpaul michaelpaul approved these changes

@Aleffio Aleffio Awaiting requested review from Aleffio

@AlexandrosMor AlexandrosMor Awaiting requested review from AlexandrosMor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wboereboom @michaelpaul @Aleffio @AlexandrosMor @jillingk