Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for renaming payment methods in Drop-in #259

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Added support for renaming payment methods in Drop-in #259

merged 4 commits into from
Sep 17, 2024

Conversation

Robert-SD
Copy link
Collaborator

No description provided.

@Robert-SD Robert-SD linked an issue Sep 5, 2024 that may be closed by this pull request
How to Customise Drop-UI in Flutter SDK? #227
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

LCOV of commit 1549967 during Check PR #813

Summary coverage rate:
  lines......: 10.6% (136 of 1285 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/drop_in/model/drop_in_configuration.dart                                              | 100%      1|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |65.2%    181|    -     0|    -      0

Robert-SD
Robert-SD commented Sep 17, 2024
View reviewed changes
android/src/main/kotlin/com/adyen/checkout/flutter/PlatformApi.kt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code - no review required.

Robert-SD
Robert-SD commented Sep 17, 2024
View reviewed changes
lib/src/generated/platform_api.g.dart
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code - no review required.

Robert-SD
Robert-SD commented Sep 17, 2024
View reviewed changes
ios/Classes/PlatformApi.swift
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code - no review required.

@github-actions GitHub Actions
Copy link

LCOV of commit 25926dc during Check PR #835

Summary coverage rate:
  lines......: 10.6% (136 of 1285 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                                                                                |Lines       |Functions  |Branches    
  Filename                                                                                      |Rate     Num|Rate    Num|Rate     Num
  ====================================================================================================================================
  lib/src/drop_in/model/drop_in_configuration.dart                                              | 100%      1|    -     0|    -      0
  lib/src/util/dto_mapper.dart                                                                  |65.2%    181|    -     0|    -      0

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Robert-SD Robert-SD merged commit dcf98c4 into main Sep 17, 2024
13 of 14 checks passed
@Robert-SD Robert-SD deleted the feature/DropInPaymentMethodNameChange branch September 17, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@descorp descorp descorp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to Customise Drop-UI in Flutter SDK?
2 participants
@Robert-SD @descorp