Analytics - Track submit event after validation #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
araratthehero
added
the
Chore
araratthehero
force-pushed
the
feature/analytics_track_submit_after_validation
branch
3 times, most recently
from
2ae379a to
3aeaf1c
Compare
araratthehero
force-pushed
the
feature/analytics_track_submit_after_validation
branch
3 times, most recently
from
5920a31 to
80cf8b6
Compare
araratthehero
force-pushed
the
feature/analytics_track_submit_after_validation
branch
2 times, most recently
from
3aff097 to
f676b53
Compare
jreij
reviewed
Dec 12, 2024
ach/src/main/java/com/adyen/checkout/ach/internal/ui/DefaultACHDirectDebitDelegate.kt
Show resolved
Hide resolved
araratthehero
force-pushed
the
feature/analytics_track_submit_after_validation
branch
from
f676b53 to
99b525f
Compare
araratthehero
force-pushed
the
feature/analytics_track_submit_after_validation
branch
from
99b525f to
a0074bb
Compare
✅ No public API changes |
|
jreij
approved these changes
Dec 17, 2024
araratthehero
deleted the
feature/analytics_track_submit_after_validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were tracking the submit event regardless if the component data was valid or not, but this PR fixes it. Here we track events when there are values emitted in the
submitFlow, which happens when theonSubmit()is called and the component is valid.Checklist
COAND-1038