Fix existing string resources with multiple substitutions #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarSpruit
previously approved these changes
Apr 5, 2024
We cannot fix this in smartling yet so for now we'll manually fix checkout_card_installments_option_regular_with_price Note that in Italian the order of the arguments is flipped on purpose COAND-879
COAND-879
jreij
force-pushed
the
fix/string-resources-with-multiple-substitutions
branch
from
c181b1a to
4c3e081
Compare
|
OscarSpruit
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
checkout_card_installments_option_regular_with_pricewhich was causing build warnings.Checklist
COAND-879