Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onAdditionalDetails being called multiple times #1549

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

OscarSpruit
Copy link
Contributor

Description

The issue was caused by the status polling emitting the final value multiple times. By merging and cancelling the flows in StatusRepository and adding debounce the issue is solved.

Checklist

  • Code is unit tested
  • Changes are tested manually
  • Link to related issues
  • Add relevant labels to PR

COAND-883

@OscarSpruit OscarSpruit added the Fix [PRs only] Indicates a bug fix label Apr 3, 2024
@OscarSpruit OscarSpruit requested a review from a team as a code owner April 3, 2024 12:42
@OscarSpruit OscarSpruit linked an issue Apr 3, 2024 that may be closed by this pull request
@OscarSpruit OscarSpruit force-pushed the fix/status_polling branch 3 times, most recently from 43f6745 to 20d8a5e Compare April 8, 2024 09:43
Copy link

sonarqubecloud bot commented Apr 8, 2024

This fixes an issue where a status could be fetched multiple times at once, causing the
/payments/details call to be triggered multiple times.

COAND-883
@OscarSpruit OscarSpruit merged commit ca58dfe into develop Apr 9, 2024
6 of 7 checks passed
@OscarSpruit OscarSpruit deleted the fix/status_polling branch April 9, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix [PRs only] Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v5.3.0] onAdditionalDetails called twice with BLIK payment
2 participants