-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Add leading dimension to object for multi-slice #314
API: Add leading dimension to object for multi-slice #314
Conversation
…gation through a 3D sample and how it is affected using a 3PIE fold_slice style of 3D sample updates. This is my first attempt at pushing a unittest, and I'm sure I'm messing something up...
… 64 scan positions)
…rator contains multislice propagator array
…g from fresnelmultislice inside multislice class
Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-05-28 17:44:57 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few random comments:
-
In convolution.py, it looks like we just have a name change of the class (e.g. Convolution --> ConvolutionFFT)?
-
In tests/ptycho/io.py, it still seems like it should be average instead of sum for plotting phase and magnitude of sample...this is also closer to what fold_slice does for the final 2D sample projection for sinogram creation
-
The new unit tests for the stuff changed look OK, I haven't run them since I'm not sure about the bigger context of what they're testing.
-
Fresnel Spect Prop has been removed from this; will be reintroduced in subsequent pull request.
-
Introduced a SingleSlice instance of Multislice class in order to make this whole TIKE single slice --> TIKE multislice upgrade process easier to follow.
Purpose
Adds a leading dimension to the reconstructed object in preparation for multi-slice objects.
Approach
Pre-Merge Checklists
Submitter
Reviewer