Skip to content

Commit

Permalink
[WIP] Complain about invalid sources again
Browse files Browse the repository at this point in the history
This used to be a local ROOT patch of Clang
(vgvassilev/clang@a5ee33ae48)
However, after trying to upstream it, there're two tests broken:

* Modules/module-file-modified.c
* Modules/explicit-build-missing-files.cpp

I have talked with Vassil briefly and he said this change has something
to do with virtual files. Let's try to revert this and see how ROOT's
tests break. Ideally we'll find a more appropriate approach.
  • Loading branch information
junaire authored and vgvassilev committed May 26, 2022
1 parent 9b99914 commit 1b2afa8
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1497,7 +1497,7 @@ bool ASTReader::ReadSLocEntry(int ID) {
// We will detect whether a file changed and return 'Failure' for it, but
// we will also try to fail gracefully by setting up the SLocEntry.
unsigned InputID = Record[4];
InputFile IF = getInputFile(*F, InputID, /*Complain=*/false);
InputFile IF = getInputFile(*F, InputID);
const FileEntry *File = IF.getFile();
bool OverriddenBuffer = IF.isOverridden();

Expand Down

0 comments on commit 1b2afa8

Please sign in to comment.