Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic - FBI-287 - Request example generation for Curl and Python #4

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

rishitank
Copy link

@rishitank rishitank commented Jun 13, 2023

What/Why/How?

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

Copy link

@kamukondiwa kamukondiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, see my suggestions.


// Add Authentication Header if provided
this.apiKeys
.filter(scheme => scheme.in === 'header')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be a constant

}
}

if (!reqHeaders.get('Accept')) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be a constant


if (this.requestBody?.mediaTypes.length) {
const [mediaType] = this.requestBody.mediaTypes;
if (!mediaType.name.includes('form-data')) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be a constant

@rishitank rishitank marked this pull request as ready for review June 26, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants