Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing event injection commit #846

Merged
merged 1 commit into from
May 7, 2019
Merged

fix: missing event injection commit #846

merged 1 commit into from
May 7, 2019

Conversation

veegandhi
Copy link
Contributor

Description

Patch injected event missing commit when Popover PR was pushed.

Does this PR introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

Screenshots (if appropriate):

Check-list:

  • I have read the Contributing document.
  • I've thought about and labelled my PR/commit message appropriately.
  • If this PR introduces breaking changes I've described the impact and migration path for existing applications.
  • CI is green (coverage, linting, tests).
  • I have updated the documentation accordingly.
  • I've two LGTMs/Approvals.
  • I've fixed or replied to all my code-review comments.
  • I've manually tested with a buddy.
  • I've squashed my commits into one.

@codecov-io
Copy link

Codecov Report

Merging #846 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #846   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          69     69           
  Lines        1007   1006    -1     
  Branches      230    229    -1     
=====================================
- Hits         1007   1006    -1
Impacted Files Coverage Δ
src/components/third-party/Popover/index.jsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912d07c...39a741f. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #846 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #846   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          69     69           
  Lines        1007   1006    -1     
  Branches      230    229    -1     
=====================================
- Hits         1007   1006    -1
Impacted Files Coverage Δ
src/components/third-party/Popover/index.jsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912d07c...39a741f. Read the comment docs.

Copy link
Contributor

@lightbringer1991 lightbringer1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lightbringer1991
Copy link
Contributor

merging ...

@lightbringer1991 lightbringer1991 merged commit f53dd5d into master May 7, 2019
@lightbringer1991 lightbringer1991 deleted the fix-commit branch May 7, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants