Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix package-lock and add git diff check #842

Merged
merged 1 commit into from
May 2, 2019

Conversation

bchew
Copy link
Member

@bchew bchew commented May 2, 2019

Description

  • fix package-lock
  • switch to use npm install instead of npm ci so that we can validate changes
  • add git diff check to fail CI to catch incorrect package-lock changes

Motivation and Background Context

Although npm ci is faster, changing travis-ci to use npm install instead so that we can catch incorrectly pushed package-lock changes.

Does this PR introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

Screenshots (if appropriate):

Check-list:

  • I have read the Contributing document.
  • I've thought about and labelled my PR/commit message appropriately.
  • If this PR introduces breaking changes I've described the impact and migration path for existing applications.
  • CI is green (coverage, linting, tests).
  • I have updated the documentation accordingly.
  • I've two LGTMs/Approvals.
  • I've fixed or replied to all my code-review comments.
  • I've manually tested with a buddy.
  • I've squashed my commits into one.

- fix package-lock
- switch to use npm install instead of npm ci so that we can validate changes
- add git diff check to fail CI to catch incorrect package-lock changes
Copy link
Contributor

@xiaofan2406 xiaofan2406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented May 2, 2019

Codecov Report

Merging #842 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #842   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          69     69           
  Lines        1007   1007           
  Branches      230    230           
=====================================
  Hits         1007   1007

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f41ae...723bf7e. Read the comment docs.

Copy link
Contributor

@lightbringer1991 lightbringer1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lightbringer1991
Copy link
Contributor

merging...

@lightbringer1991 lightbringer1991 merged commit 6332fe2 into master May 2, 2019
@lightbringer1991 lightbringer1991 deleted the fix-package-lock branch May 2, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants