Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use npm v6.9.0 #834

Merged
merged 1 commit into from
Apr 4, 2019
Merged

chore: use npm v6.9.0 #834

merged 1 commit into from
Apr 4, 2019

Conversation

bchew
Copy link
Member

@bchew bchew commented Apr 3, 2019

Description

  • update package-lock files
  • update travis-ci yml file to use npm v6.9.0

Motivation and Background Context

Does this PR introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

Screenshots (if appropriate):

Check-list:

  • I have read the Contributing document.
  • I've thought about and labelled my PR/commit message appropriately.
  • If this PR introduces breaking changes I've described the impact and migration path for existing applications.
  • CI is green (coverage, linting, tests).
  • I have updated the documentation accordingly.
  • I've two LGTMs/Approvals.
  • I've fixed or replied to all my code-review comments.
  • I've manually tested with a buddy.
  • I've squashed my commits into one.

@bchew bchew changed the title chore: upgrade node to v8.15.1, npm to v6.9.0 chore: use npm v6.9.0 Apr 3, 2019
@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #834 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #834   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          67     67           
  Lines         967    967           
  Branches      209    209           
=====================================
  Hits          967    967

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd7689...89e6495. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #834 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #834   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          67     67           
  Lines         967    967           
  Branches      209    209           
=====================================
  Hits          967    967

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddd7689...89e6495. Read the comment docs.

Copy link
Contributor

@pphminions pphminions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍏

@pphminions
Copy link
Contributor

Merging 🚀

@pphminions pphminions merged commit 0e4aa10 into master Apr 4, 2019
@pphminions pphminions deleted the node-npm-upgrade branch April 4, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants