Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Status Pill #830

Merged
merged 1 commit into from
Mar 29, 2019
Merged

New: Status Pill #830

merged 1 commit into from
Mar 29, 2019

Conversation

ChaoLiangSuper
Copy link
Contributor

@ChaoLiangSuper ChaoLiangSuper commented Mar 28, 2019

Description

Add new component StatusPill

Motivation and Background Context

Does this PR introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

Screenshots (if appropriate):

Screen Shot 2019-03-28 at 3 02 33 pm

Check-list:

  • I have read the Contributing document.
  • I've thought about and labelled my PR/commit message appropriately.
  • If this PR introduces breaking changes I've described the impact and migration path for existing applications.
  • CI is green (coverage, linting, tests).
  • I have updated the documentation accordingly.
  • I've two LGTMs/Approvals.
  • I've fixed or replied to all my code-review comments.
  • I've manually tested with a buddy.
  • I've squashed my commits into one.

@codecov-io
Copy link

codecov-io commented Mar 28, 2019

Codecov Report

Merging #830 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #830   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          65     66    +1     
  Lines         941    946    +5     
  Branches      199    199           
=====================================
+ Hits          941    946    +5
Impacted Files Coverage Δ
src/components/adslot-ui/StatusPill/index.jsx 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3c2f2...c64867b. Read the comment docs.

@ChaoLiangSuper ChaoLiangSuper force-pushed the add-status-pill branch 2 times, most recently from 7bf2d15 to 4c46a3c Compare March 28, 2019 23:23
@nimishjha nimishjha merged commit 16f849c into master Mar 29, 2019
@nimishjha nimishjha deleted the add-status-pill branch March 29, 2019 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants