Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checkbox doc #827

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Update checkbox doc #827

merged 1 commit into from
Mar 27, 2019

Conversation

ChaoLiangSuper
Copy link
Contributor

@ChaoLiangSuper ChaoLiangSuper commented Mar 27, 2019

Description

  • Add the onChange definition for checkbox component

Motivation and Background Context

Does this PR introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

Screenshots (if appropriate):

Check-list:

  • I have read the Contributing document.
  • I've thought about and labelled my PR/commit message appropriately.
  • If this PR introduces breaking changes I've described the impact and migration path for existing applications.
  • CI is green (coverage, linting, tests).
  • I have updated the documentation accordingly.
  • I've two LGTMs/Approvals.
  • I've fixed or replied to all my code-review comments.
  • I've manually tested with a buddy.
  • I've squashed my commits into one.

@codecov-io
Copy link

codecov-io commented Mar 27, 2019

Codecov Report

Merging #827 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #827   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          65     65           
  Lines         941    941           
  Branches      199    199           
=====================================
  Hits          941    941

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 200c262...83cb9ca. Read the comment docs.

@ChaoLiangSuper ChaoLiangSuper force-pushed the update-checkbox-docwq branch from 911d199 to 83cb9ca Compare March 27, 2019 04:34
@vinteo
Copy link
Member

vinteo commented Mar 27, 2019

Merging...

@vinteo vinteo merged commit ba3c2f2 into master Mar 27, 2019
@vinteo vinteo deleted the update-checkbox-docwq branch March 27, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants