Import Alexandria #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add note to Readme about how to profile the webpack dist. - Finally decide that react-bootstrap is a dev dependency and we should ship the parts we're exporting. This way we can load only the modules we use in Direct and Symphony etc. - Update package.json to point to public npm and our git repo.
|
|
||
| To generate a profile: `npm run profile` | ||
|
|
||
| Upload the new `stats.json` file to [Webpack Analyse Tool](http://webpack.github.io/analyse). |
There was a problem hiding this comment.
Interesting they use the Queen's English in the URL. I thought you might've overcorrected but it checks out.
|
LGTM 💚 |
|
Merging 🍜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should ship the parts we're exporting. This way we can load only the
modules we use in Direct and Symphony etc.