[ADS-973] Fix wrapAround error on 3rd party carousel lib #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoLiangSuper
force-pushed
the
upgrade-carousel
branch
2 times, most recently
from
d873735 to
b5096a1
Compare
|
this is more like changing from official to your fork, what's the improvement on it, is it just a fix for first image disappears? also it would be nice if there is an issue in the original package and/or a pull request to fix it |
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 54 54
Lines 778 778
Branches 156 156
=====================================
Hits 778 778Continue to review full report at Codecov.
|
|
@lightbringer1991 I will add it later. Currently testing on a local branch. Still WIP. |
ChaoLiangSuper
changed the title
ChaoLiangSuper
force-pushed
the
upgrade-carousel
branch
from
b5096a1 to
f88adf9
Compare
ChaoLiangSuper
changed the title
|
LGTMerging 🍜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade 3rd party carousel lib to 4.0.1 and add fix commit for the first image disappearTried to upgrade to 4., but it is not solving this bug.
Have to fork fjaskolski's fix on (https://github.com/fjaskolski/nuka-carousel)
The version of this lib is still remaining to 3.0.1.
If this bug can be solved on version 4. , we can upgrade to 4.* later.
Description
Motivation and Background Context
Does this PR introduce a breaking change?
How Has This Been Tested?
Screenshots (if appropriate):
Check-list: