Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dist error #672

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Fix: dist error #672

merged 1 commit into from
Dec 11, 2017

Conversation

xiaofan2406
Copy link
Contributor

change the env preset so that it does transpile to commonjs modules. Because src/dist-entry/index.js uses module.exorts instead of es6 modules.

Ideally, we can utilise babel export extension plugin to fix src/dist-entry/index.js, but for now this fix should work

And subsequently need to modify hot-reloader setup.

@codecov-io
Copy link

codecov-io commented Dec 11, 2017

Codecov Report

Merging #672 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #672   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          54     54           
  Lines         767    767           
  Branches      156    156           
=====================================
  Hits          767    767

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8addfe...f55e021. Read the comment docs.

@omgaz
Copy link
Contributor

omgaz commented Dec 11, 2017

Looks like it fixes it locally after I use this branch and re-install my node dependencies. Will re-run and see if it resolves.

@omgaz omgaz merged commit 5536c2b into master Dec 11, 2017
@omgaz omgaz deleted the fix-dist branch December 11, 2017 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants