New: AlertInput onFocus prop addition #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 49 49
Lines 691 693 +2
Branches 144 145 +1
=====================================
+ Hits 691 693 +2
Continue to review full report at Codecov.
|
adityasabnis
force-pushed
the
alert-input-onfocus-prop
branch
from
5b01d5c to
7580eb1
Compare
| @@ -46,6 +46,10 @@ export default class AlertInput extends Component { | |||
| isFocused: true, | |||
| isPopoverVisible: Boolean(this.props.alertMessage), | |||
| }); | |||
|
|
|||
| if (this.props.onFocus) { | |||
| this.props.onFocus(event); | |||
There was a problem hiding this comment.
probably just default to _.noop so you don't have to make this check
There was a problem hiding this comment.
I disagree, I think this check is valid and preferable to a noop for consistency with other types and for providing explicitness with the optional parameters.
sharmajyo
approved these changes
Oct 18, 2017
mdotwills
approved these changes
Oct 18, 2017
|
Discussion outcome for moving to noop: Stick to existing. |
|
Merged.. ⏰ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
onFocuspropType function toAlertInputResolves: #637