-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: treepicker simple pure option to hide the svg icon #465
Conversation
Current coverage is 100% (diff: 100%)@@ master #465 diff @@
====================================
Files 26 26
Lines 407 407
Methods 64 64
Messages 0 0
Branches 74 74
====================================
Hits 407 407
Misses 0 0
Partials 0 0
|
selectedNodes={[]} | ||
subtree={this.state.treePickerPureSubtree} | ||
emptySelectedListText={<div><h><b>Choose items of interest</b></h></div>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the <h>
tag for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh a mistake @vinteo, will remove that, just wanted to show emptySelectedListText
can contain anything :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0d74d8a
to
2cee378
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vinteo/ @omgaz - please merge |
Merging 🚀 |
To have the option to remove the svg icon from the selected side of the tree picker