Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: treepicker simple pure option to hide the svg icon #465

Merged
merged 1 commit into from
Dec 8, 2016

Conversation

pphminions
Copy link
Contributor

@pphminions pphminions commented Dec 7, 2016

To have the option to remove the svg icon from the selected side of the tree picker

screen shot 2016-12-08 at 9 18 31 am

@pphminions pphminions requested a review from omgaz December 7, 2016 22:19
@codecov-io
Copy link

codecov-io commented Dec 7, 2016

Current coverage is 100% (diff: 100%)

Merging #465 into master will not change coverage

@@           master   #465   diff @@
====================================
  Files          26     26          
  Lines         407    407          
  Methods        64     64          
  Messages        0      0          
  Branches       74     74          
====================================
  Hits          407    407          
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 5d6d7e7...2cee378

selectedNodes={[]}
subtree={this.state.treePickerPureSubtree}
emptySelectedListText={<div><h><b>Choose items of interest</b></h></div>}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the <h> tag for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh a mistake @vinteo, will remove that, just wanted to show emptySelectedListText can contain anything :)

Copy link
Member

@vinteo vinteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pphminions pphminions force-pushed the tree-picker-hide-icon-support branch from 0d74d8a to 2cee378 Compare December 7, 2016 23:01
Copy link
Contributor

@omgaz omgaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pphminions
Copy link
Contributor Author

@vinteo/ @omgaz - please merge

@omgaz
Copy link
Contributor

omgaz commented Dec 8, 2016

Merging 🚀

@omgaz omgaz merged commit a4fc36c into master Dec 8, 2016
@omgaz omgaz deleted the tree-picker-hide-icon-support branch December 8, 2016 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants