Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade svg plugin #1852

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore: upgrade svg plugin #1852

merged 1 commit into from
Jul 23, 2024

Conversation

xiaofan2406
Copy link
Contributor

@xiaofan2406 xiaofan2406 commented Jul 23, 2024

Description

upgrade vite-plugin-svg, used by storybook for demo atm

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

Copy link

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (2c5c7fb) to head (905669b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1852   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files         102      102           
  Lines        1962     1962           
  Branches      569      571    +2     
=======================================
  Hits         1957     1957           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pphminions pphminions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🫧

@pphminions
Copy link
Contributor

merging 🚀

@pphminions pphminions merged commit 9086eea into master Jul 23, 2024
10 checks passed
@pphminions pphminions deleted the svgplugin branch July 23, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants