-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree picker dts #1686
Tree picker dts #1686
Conversation
Codecov Report
@@ Coverage Diff @@
## tree-picker #1686 +/- ##
============================================
Coverage 99.74% 99.74%
============================================
Files 102 102
Lines 1940 1940
Branches 529 529
============================================
Hits 1935 1935
Misses 5 5
|
d046c39
to
39bbdb0
Compare
@@ -19,6 +19,7 @@ const HeaderAddAll = () => { | |||
<Button | |||
variant="link" | |||
className="aui--tree-picker-header-add-all" | |||
dts="add-all-button" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this
const header = useTreePickerSlice(getCurrentNodeHeader); | ||
|
||
const finalLabel = !_.isUndefined(header) ? header : label; | ||
|
||
return !finalLabel ? null : ( | ||
<div className={cc('aui--tree-picker-row', 'aui--tree-picker-header', className)}> | ||
<div className={cc('aui--tree-picker-row', 'aui--tree-picker-header', className)} dts={dts}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-test-selector={dts}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the expandDts util for all places
39bbdb0
to
c1fcf34
Compare
c1fcf34
to
58318a4
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Does this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):