Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADS-7903] feat: new tree picker #1680

Merged
merged 4 commits into from
Oct 23, 2023
Merged

[ADS-7903] feat: new tree picker #1680

merged 4 commits into from
Oct 23, 2023

Conversation

xiaofan2406
Copy link
Contributor

@xiaofan2406 xiaofan2406 commented Aug 22, 2023

Description

The new TreePicker in this PR is eventually going to replace the current tree picker. However for legacy reasons, the current tree picker is exported as TreePickerSimplePure, this PR wont be a breaking change.

The new TreePicker is encouraging composition over encapsulation. A basic example looks like

<TreePicker
  renderNode={(node) => (
    <TreePicker.Node node={node}>
      <TreePicker.Node.Content>{node.label}</TreePicker.Node.Content>
      <TreePicker.Node.Expand resolveNodes={() => []} />
      <TreePicker.Node.Add onAdd={() => {}} />
    </TreePicker.Node>
  )}
>
  <TreePicker.Nav />
  <TreePicker.Search resolveNodes={() => []} />
  <TreePicker.Tree resolveRootNodes={() => []} />
</TreePicker>

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

@xiaofan2406 xiaofan2406 changed the title Tree picker feat: new tree picker Aug 22, 2023
@chaofan232 chaofan232 force-pushed the tree-picker branch 2 times, most recently from d73b327 to 5514c01 Compare August 30, 2023 04:30
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #1680 (dcbf667) into master (4a6f6fd) will decrease coverage by 0.26%.
The diff coverage is 98.40%.

@@             Coverage Diff             @@
##            master    #1680      +/-   ##
===========================================
- Coverage   100.00%   99.74%   -0.26%     
===========================================
  Files           93      102       +9     
  Lines         1627     1940     +313     
  Branches       469      529      +60     
===========================================
+ Hits          1627     1935     +308     
- Misses           0        5       +5     
Files Coverage Δ
src/components/ListPickerPure/index.jsx 100.00% <ø> (ø)
src/components/RadioGroup/index.jsx 100.00% <ø> (ø)
src/components/TreePicker/TreePicker.jsx 100.00% <100.00%> (ø)
src/components/TreePicker/TreePickerHeader.jsx 100.00% <100.00%> (ø)
src/components/TreePicker/TreePickerNav.jsx 100.00% <100.00%> (ø)
src/components/TreePicker/TreePickerNode.jsx 100.00% <100.00%> (ø)
src/components/TreePicker/TreePickerSearch.jsx 100.00% <100.00%> (ø)
src/components/TreePicker/TreePickerTree.jsx 100.00% <100.00%> (ø)
src/components/TreePickerSimplePure/Grid/index.jsx 100.00% <ø> (ø)
src/components/TreePickerSimplePure/Nav/index.jsx 100.00% <ø> (ø)
... and 6 more

@xiaofan2406 xiaofan2406 force-pushed the tree-picker branch 4 times, most recently from b1bf828 to c244501 Compare August 31, 2023 02:16
@xiaofan2406 xiaofan2406 force-pushed the tree-picker branch 2 times, most recently from dc4fe00 to ec22e4d Compare September 4, 2023 00:06
@xiaofan2406 xiaofan2406 force-pushed the tree-picker branch 3 times, most recently from 88b02b3 to 42972c3 Compare September 20, 2023 01:25
pphminions
pphminions previously approved these changes Sep 20, 2023
Copy link
Contributor

@pphminions pphminions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📟

vinteo
vinteo previously approved these changes Sep 20, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xiaofan2406 xiaofan2406 changed the title feat: new tree picker [ADS-7903] feat: new tree picker Oct 23, 2023
@vinteo
Copy link
Member

vinteo commented Oct 23, 2023

Merging...

@vinteo vinteo merged commit ff5fa9e into master Oct 23, 2023
9 of 11 checks passed
@vinteo vinteo deleted the tree-picker branch October 23, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants