-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADS-7903] feat: new tree picker #1680
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaofan2406
force-pushed
the
tree-picker
branch
from
August 22, 2023 01:32
7a7fe20
to
3333b9b
Compare
chaofan232
force-pushed
the
tree-picker
branch
2 times, most recently
from
August 30, 2023 04:30
d73b327
to
5514c01
Compare
Codecov Report
@@ Coverage Diff @@
## master #1680 +/- ##
===========================================
- Coverage 100.00% 99.74% -0.26%
===========================================
Files 93 102 +9
Lines 1627 1940 +313
Branches 469 529 +60
===========================================
+ Hits 1627 1935 +308
- Misses 0 5 +5
|
xiaofan2406
force-pushed
the
tree-picker
branch
4 times, most recently
from
August 31, 2023 02:16
b1bf828
to
c244501
Compare
chaofan232
force-pushed
the
tree-picker
branch
from
September 1, 2023 06:40
c244501
to
283291d
Compare
xiaofan2406
force-pushed
the
tree-picker
branch
2 times, most recently
from
September 4, 2023 00:06
dc4fe00
to
ec22e4d
Compare
chaofan232
force-pushed
the
tree-picker
branch
from
September 4, 2023 06:02
ec22e4d
to
29025de
Compare
xiaofan2406
force-pushed
the
tree-picker
branch
3 times, most recently
from
September 20, 2023 01:25
88b02b3
to
42972c3
Compare
chaofan232
force-pushed
the
tree-picker
branch
from
September 20, 2023 04:05
42972c3
to
17c8910
Compare
pphminions
previously approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 📟
vinteo
previously approved these changes
Sep 20, 2023
xiaofan2406
force-pushed
the
tree-picker
branch
3 times, most recently
from
October 16, 2023 05:18
8e1e54c
to
e2df7c3
Compare
chaofan232
force-pushed
the
tree-picker
branch
from
October 17, 2023 00:46
e2df7c3
to
f9697b7
Compare
xiaofan2406
force-pushed
the
tree-picker
branch
from
October 17, 2023 03:36
f9697b7
to
4019430
Compare
xiaofan2406
force-pushed
the
tree-picker
branch
from
October 17, 2023 03:39
4019430
to
7402f0b
Compare
xiaofan2406
force-pushed
the
tree-picker
branch
from
October 17, 2023 23:09
7402f0b
to
dcbf667
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
vinteo
approved these changes
Oct 23, 2023
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
TreePicker
in this PR is eventually going to replace the current tree picker. However for legacy reasons, the current tree picker is exported asTreePickerSimplePure
, this PR wont be a breaking change.The new
TreePicker
is encouraging composition over encapsulation. A basic example looks likeDoes this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):