Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install ts #1626

Merged
merged 1 commit into from
May 14, 2023
Merged

fix: install ts #1626

merged 1 commit into from
May 14, 2023

Conversation

xiaofan2406
Copy link
Contributor

@xiaofan2406 xiaofan2406 commented May 12, 2023

Description

install ts as dev dep so we know which version it is running the type checking on

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1626 (7347e58) into master (0dbb076) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1626   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           96        96           
  Lines         1703      1703           
  Branches       477       477           
=========================================
  Hits          1703      1703           

@bchew bchew merged commit 8e03fae into master May 14, 2023
@bchew bchew deleted the fix-ts branch May 14, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants