feat: focus utils #1556
Open
feat: focus utils #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1556 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 96 100 +4
Lines 1703 1737 +34
Branches 477 501 +24
=========================================
+ Hits 1703 1737 +34
... and 13 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Kudos, SonarCloud Quality Gate passed!
|
renrizzolo
force-pushed
the
focus
branch
4 times, most recently
from
f226c62 to
ac9795b
Compare
renrizzolo
force-pushed
the
focus
branch
2 times, most recently
from
d9f1703 to
b4ad404
Compare
renrizzolo
force-pushed
the
focus
branch
2 times, most recently
from
7cb2910 to
ee1064a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NB This is part 1 of an effort to refactor popover and add a new dropdown menu component.
Add some focus utils, namely a tree walker that allows us to get all focussable/tabbable nodes within an element
Add
DismissableFocusTrapcomponent. As this is intended for use with portaled UI elements like modals, menus and popovers, it combines focus trapping and escape/click outside dismiss behaviour. This could be separated into 2 components (FocusTrap / Dismissable) if preferred.Implement the focus trap in the
ActionPanelcomponentReference: https://www.w3.org/WAI/ARIA/apg/patterns/dialogmodal/
Does this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):