Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADS-5897] React18 #1523

Merged
merged 4 commits into from
Jun 15, 2023
Merged

[ADS-5897] React18 #1523

merged 4 commits into from
Jun 15, 2023

Conversation

xiaofan2406
Copy link
Contributor

@xiaofan2406 xiaofan2406 commented Nov 24, 2022 •
edited
Loading

Description

  • deprecate fastStatelessWrapper, as it does not do what it is supposed to do, use React.memo
  • deprecate HoverDropdownMenu, as it is not used, and should be used with Popover and custom menu content
  • deprecate Toast.Notification, as it has a bug and should use Toast.notify as a replacement
  • upgrade React 18

internal

  • lowered coverage percentage to 95%
  • react testing lib v13
  • migrate most events to use user-events v14, (except for RichTextEditor)
  • fix some tests had incorrect mocking for console.error which silenced lots of valid errors
  • separated out invariant to a isolated file and ignore by coverage since it is auto mocked during test
  • update linting setup for test files

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

@xiaofan2406 xiaofan2406 force-pushed the react18 branch 7 times, most recently from 9dd8b39 to 0e37082 Compare November 25, 2022 04:08
@codecov
Copy link

codecov bot commented Nov 25, 2022 •
edited
Loading

Codecov Report

Merging #1523 (d4edfd1) into master (8e03fae) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1523   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           96        93    -3     
  Lines         1703      1627   -76     
  Branches       477       466   -11     
=========================================
- Hits          1703      1627   -76
Impacted Files Coverage Δ
src/components/Anchor/index.jsx 100.00% <ø> (ø)
src/components/Breadcrumb/index.jsx 100.00% <ø> (ø)
src/components/Button/index.jsx 100.00% <ø> (ø)
src/components/Checkbox/index.jsx 100.00% <ø> (ø)
src/components/CheckboxGroup/index.jsx 100.00% <ø> (ø)
src/components/ConfirmModal/index.jsx 100.00% <ø> (ø)
src/components/ListPicker/index.jsx 100.00% <ø> (ø)
src/components/ListPickerPure/index.jsx 100.00% <ø> (ø)
src/components/Radio/index.jsx 100.00% <ø> (ø)
src/components/RadioGroup/index.jsx 100.00% <ø> (ø)
... and 11 more

@xiaofan2406 xiaofan2406 force-pushed the react18 branch 13 times, most recently from 4cadef4 to 2d29c0d Compare November 30, 2022 05:58
@xiaofan2406 xiaofan2406 force-pushed the react18 branch 2 times, most recently from 72aa403 to 549b797 Compare December 16, 2022 00:15
@sonarcloud
Copy link

sonarcloud bot commented Dec 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xiaofan2406 xiaofan2406 force-pushed the react18 branch 2 times, most recently from af4702a to 2d36e62 Compare January 23, 2023 23:34
@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xiaofan2406 xiaofan2406 force-pushed the react18 branch 3 times, most recently from 28f3848 to 1c88c8f Compare March 6, 2023 02:23
xiaofan2406
xiaofan2406 commented Mar 15, 2023
View reviewed changes
package.json
},
"engines": {
"node": "^18"
},
"overrides": {
"@testing-library/dom": "^9.0.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing-library/user-event#1104

@xiaofan2406 xiaofan2406 force-pushed the react18 branch 4 times, most recently from a3f1963 to b9faca8 Compare March 22, 2023 00:39
@xiaofan2406 xiaofan2406 force-pushed the react18 branch 4 times, most recently from df7f362 to e94236e Compare March 30, 2023 06:27
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 30, 2023
View reviewed changes
scripts/babel-build.js
@@ -43,7 +36,7 @@

const command = ['npx babel', ...babelArgs].join(' ');

const { stderr, stdout } = await exec(command, { env: { ...process.env, ...env } });
const { stderr } = await exec(command, { env: { ...process.env, ...env } });

Check warning

Code scanning / CodeQL

Shell command built from environment values

This shell command depends on an uncontrolled [absolute path](1). This shell command depends on an uncontrolled [absolute path](2). This shell command depends on an uncontrolled [absolute path](3). This shell command depends on an uncontrolled [absolute path](4).
@xiaofan2406 xiaofan2406 force-pushed the react18 branch 4 times, most recently from 75f3563 to 9c6e8fe Compare March 30, 2023 23:06
@sonarcloud
Copy link

sonarcloud bot commented Mar 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xiaofan2406 xiaofan2406 force-pushed the react18 branch 3 times, most recently from 9378730 to 14a4b22 Compare May 12, 2023 03:39
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shn2016
Copy link
Contributor

shn2016 commented Jun 15, 2023

Merging...

@shn2016 shn2016 merged commit 9f30149 into master Jun 15, 2023
@shn2016 shn2016 deleted the react18 branch June 15, 2023 04:31
@xiaofan2406 xiaofan2406 changed the title React18 [ADS-5897] React18 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shn2016 shn2016 shn2016 approved these changes

@vinteo vinteo vinteo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaofan2406 @shn2016 @vinteo