Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix propType descriptions #1457

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

renrizzolo
Copy link
Contributor

Description

Map the lines of description in the docs propTypes table so JSDOC descriptions are more readable
Fix some missing propType descriptions for Radio, CheckBox, Anchor

Does this PR introduce a breaking change?

  • Yes
  • No

screen_shot_2022-07-11_at_11 03 19_am

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1457 (0f9a5ca) into master (231c3bc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1457   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           96        96           
  Lines         1560      1558    -2     
  Branches       435       435           
=========================================
- Hits          1560      1558    -2     
Impacted Files Coverage Δ
src/components/Anchor/index.jsx 100.00% <ø> (ø)
src/components/Button/index.jsx 100.00% <ø> (ø)
src/components/Checkbox/index.jsx 100.00% <ø> (ø)
src/components/CheckboxGroup/index.jsx 100.00% <ø> (ø)
src/components/Radio/index.jsx 100.00% <ø> (ø)
src/components/RadioGroup/index.jsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231c3bc...0f9a5ca. Read the comment docs.

@renrizzolo renrizzolo force-pushed the fix-radio-checkbox-docs branch from 6e7a3a0 to d1e180d Compare July 11, 2022 01:30
xiaofan2406
xiaofan2406 previously approved these changes Jul 11, 2022
@renrizzolo renrizzolo force-pushed the fix-radio-checkbox-docs branch from d1e180d to 0f9a5ca Compare July 11, 2022 01:48
@renrizzolo renrizzolo changed the title fix: propType documentation docs: fix propType descriptions Jul 11, 2022
@xiaofan2406 xiaofan2406 merged commit 885f7ce into master Jul 11, 2022
@xiaofan2406 xiaofan2406 deleted the fix-radio-checkbox-docs branch July 11, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants