refactor: convert text ellipsis to functional component #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1224 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 93 93
Lines 1385 1377 -8
Branches 344 344
=========================================
- Hits 1385 1377 -8
Continue to review full report at Codecov.
|
4 tasks
vinteo
previously approved these changes
Oct 21, 2021
xiaofan2406
reviewed
Oct 21, 2021
| trigger: 'hover', | ||
| }, | ||
| }; | ||
| React.useEffect(() => { |
There was a problem hiding this comment.
a general rule of thumb
useLayoutEffect when it uses dom ref
useEffect for all other side effects
chaofan232
force-pushed
the
convert-textellipsis
branch
from
637263f to
7d6e07c
Compare
xiaofan2406
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Convert TextEllipsis component into functional component
Does this PR introduce a breaking change?
Manual testing step?
Screenshots (if appropriate):