Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom checkbox and radio buttons #12

Merged
merged 1 commit into from
Dec 23, 2015
Merged

Added custom checkbox and radio buttons #12

merged 1 commit into from
Dec 23, 2015

Conversation

robmunro
Copy link
Contributor

Adding Checkboxes and Radio buttons to library
![screen shot 2015-12-18 at 12 28 07 pm]
screen shot 2015-12-22 at 11 00 33 am

@codecov-io
Copy link

Current coverage is 88.88%

Merging #12 into master will increase coverage by +1.38% as of f490256

@@            master     #12   diff @@
======================================
  Files            2       2       
  Stmts            8       9     +1
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit              7       8     +1
  Partial          0       0       
  Missed           1       1

Review entire Coverage Diff as of f490256

Powered by Codecov. Updated on successful CI builds.

@robmunro robmunro force-pushed the checkbox-component branch 5 times, most recently from eaf3e43 to 5390921 Compare December 22, 2015 00:02
omgaz
omgaz reviewed Dec 22, 2015
View reviewed changes
src/components/Main.js
<div className="example-component-panel">
<RadioGroup name="testRadio" value="2">
<Radio
label="Unchecked"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double indent props

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that is more of a jade thing. Jade it is hard to tell the diff between attributes and the start of an element. Not so much of a problem IMO in JSX.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robmunro robmunro force-pushed the checkbox-component branch 6 times, most recently from 9b565b9 to 4ae73c1 Compare December 23, 2015 03:58
@omgaz
Copy link
Contributor

omgaz commented Dec 23, 2015

Looks good, had a chat about tests and everything #Hairy needs proper convos in the new year

@omgaz
Copy link
Contributor

omgaz commented Dec 23, 2015

Merging 🍖

omgaz added a commit that referenced this pull request Dec 23, 2015
@omgaz
Merge pull request #12 from Adslot/checkbox-component
ae2f664 
Added custom checkbox and radio buttons
@omgaz omgaz merged commit ae2f664 into master Dec 23, 2015
@omgaz omgaz deleted the checkbox-component branch December 23, 2015 04:24
@robmunro
Copy link
Contributor Author

Totes @omgaz - not super happy with it - but I think we are going to need to use the standard renderer rather than shallow so that we can use findRenderedDOMComponentsWithTag``,scryRenderedDOMComponentsWithTag``` if we want to fix that. But that is up to you guys:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robmunro @codecov-io @omgaz