Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server whitelist 2 #686

Merged
merged 12 commits into from
Aug 7, 2020
Merged

server whitelist 2 #686

merged 12 commits into from
Aug 7, 2020

Conversation

sclassen
Copy link
Contributor

@sclassen sclassen commented Aug 6, 2020

No description provided.

@sclassen sclassen requested a review from hendrikebbers August 6, 2020 12:29
return Objects.equals(url1.getProtocol(), url2.getProtocol());
}

private static boolean isUrlHostMatching(URL wlUrl, URL url) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please us better names :)

@sclassen sclassen merged commit 4ee2162 into serverWhitelist Aug 7, 2020
@sclassen sclassen deleted the improveServerWhitelist branch August 7, 2020 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants