Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the following failed test on Windows #389

Conversation

lherschi
Copy link
Contributor

AssertionError in CacheUtilTest:
tesPathUpNoGoBasic
tesPathUpNoGoBasic2
tesPathUpNoGoBasicEvil
tesPathUpNoGoBasicEvil2
tesPathUpNoGoBasicEvilest
tesPathUpNoGoBasicLong
testNameGotHashedToo
testQueryGotHAshedToo

IOException in JNLPClassLoaderTest:
testRelativePathInNestedJars
testRelativePathInUrl

AssertionError in CacheUtilTest:
tesPathUpNoGoBasic
tesPathUpNoGoBasic2
tesPathUpNoGoBasicEvil
tesPathUpNoGoBasicEvil2
tesPathUpNoGoBasicEvilest
tesPathUpNoGoBasicLong
testNameGotHashedToo
testQueryGotHAshedToo

IOException in JNLPClassLoaderTest:
testRelativePathInNestedJars
testRelativePathInUrl
Copy link
Contributor

@judovana judovana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is windows specific on group of

   -  public void tesPathUpNoGoBasic() throws Exception {
   +   public void testPathUpNoGoBasic() throws Exception {

fixes? Anyway I can agree on e dont like them. Ok to go by me.

@lherschi
Copy link
Contributor Author

I thought this is a typo, which I corrected with. This is not necessary for troubleshooting.

@judovana judovana merged commit 3e8e24d into AdoptOpenJDK:master Aug 30, 2019
@sclassen
Copy link
Contributor

thx for fixing.
I setup a windows CI build in our internal CI. Hope this will help to prevent further regression for windows.

@karianna karianna added this to the 2.0.x milestone Sep 2, 2019
@karianna karianna added the bug Something isn't working label Sep 2, 2019
@lherschi lherschi deleted the windows_tests_fail_since_Cve181Cve182Cve185_fixes branch September 3, 2019 09:36
lherschi added a commit to lherschi/IcedTea-Web that referenced this pull request Sep 3, 2019
sclassen added a commit that referenced this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants