-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Providing a way to clean up package installs #2937
Merged
davidjgonzalez
merged 22 commits into
Adobe-Consulting-Services:master
from
jfmitchell:feature/package-garbage-collector
Feb 2, 2023
Merged
Feature: Providing a way to clean up package installs #2937
davidjgonzalez
merged 22 commits into
Adobe-Consulting-Services:master
from
jfmitchell:feature/package-garbage-collector
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2937 +/- ##
============================================
+ Coverage 54.51% 54.58% +0.06%
- Complexity 5684 5703 +19
============================================
Files 758 760 +2
Lines 30982 31092 +110
Branches 4005 4021 +16
============================================
+ Hits 16890 16971 +81
- Misses 12529 12548 +19
- Partials 1563 1573 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kwin
reviewed
Aug 23, 2022
...src/main/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionJob.java
Show resolved
Hide resolved
joerghoh
requested changes
Sep 11, 2022
.../main/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionConfig.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionJob.java
Show resolved
Hide resolved
...src/main/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionJob.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionJob.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionJob.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionJob.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionJob.java
Show resolved
Hide resolved
...in/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionScheduler.java
Outdated
Show resolved
Hide resolved
...in/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionScheduler.java
Outdated
Show resolved
Hide resolved
...test/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionJobTest.java
Outdated
Show resolved
Hide resolved
…ctor/PackageGarbageCollectionConfig.java Co-authored-by: Jörg Hoh <[email protected]>
…ctor/PackageGarbageCollectionJob.java Co-authored-by: Jörg Hoh <[email protected]>
…ctor/PackageGarbageCollectionJob.java Co-authored-by: Jörg Hoh <[email protected]>
joerghoh
requested changes
Nov 17, 2022
...src/main/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionJob.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionJob.java
Outdated
Show resolved
Hide resolved
...in/java/com/adobe/acs/commons/packagegarbagecollector/PackageGarbageCollectionScheduler.java
Show resolved
Hide resolved
joerghoh
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use Adobe Cloud Manager to deploy new code to your environments on Adobe Managed Service instances, it will generate a unique version number for your package, based on the configuration in the pom.xml file.
The downside of this approach, is that over time, multiple versions of the packages are building up in the /etc/packages part of the repository. Eventually, this leads to the exhaustion of the storage
This is a configurable scheduled job that will only run on classic installations that can be used to clear down specific packages.