Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old GenericList implementation files #2926

Conversation

SachinMali
Copy link
Contributor

@SachinMali SachinMali commented Jul 29, 2022

#2919 Remove old GenericList implementation files

... /utilities/genericlist/list.json.jsp This file has NOT been deleted as classic UI dialogs depend on JSON data via ..//_jcr_content.list.json

Verified Generic Lists Tests as

  1. Can Open, Edit existing lists
  2. Can create, and edit New existing lists
  3. And list.json works for classic custom dialogs

@SachinMali SachinMali added this to the 6.0.0 milestone Jul 29, 2022
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #2926 (4e02911) into acs-aem-commons-6.0.0 (7c4c2db) will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             acs-aem-commons-6.0.0    #2926   +/-   ##
========================================================
  Coverage                    54.52%   54.52%           
  Complexity                    5369     5369           
========================================================
  Files                          723      723           
  Lines                        29181    29181           
  Branches                      3732     3732           
========================================================
  Hits                         15912    15912           
  Misses                       11785    11785           
  Partials                      1484     1484           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@SachinMali SachinMali changed the title Acs aem commons 6.0.0 Remove old GenericList implementation files Jul 29, 2022
@davidjgonzalez davidjgonzalez merged commit db25094 into Adobe-Consulting-Services:acs-aem-commons-6.0.0 Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants