Issue #2876 - RobotsServlet Improvement #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two new OSGi config properties have been introduced: - allow.page.property.names and - disallow.page.property.names to generate ALLOW and DISALLOW rules for single pages (path/page.html) These can be combined with existing properties - allow.property.names and - disallow.property.names to ALLOW single pages (path/page.html) while DISALLOWing nested paths (path/page/), or vice versa
Codecov Report
@@ Coverage Diff @@
## master #2882 +/- ##
============================================
+ Coverage 54.05% 54.07% +0.02%
- Complexity 5609 5615 +6
============================================
Files 756 756
Lines 30779 30795 +16
Branches 3978 3981 +3
============================================
+ Hits 16637 16653 +16
Misses 12594 12594
Partials 1548 1548
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new OSGi config properties have been introduced:
to generate ALLOW and DISALLOW rules for single pages (path/page.html)
These can be combined with existing properties
to ALLOW single pages (path/page.html) while DISALLOWing nested paths (path/page/), or vice versa.
See unit tests com.adobe.acs.commons.wcm.impl.RobotsServletTest#testAllowPathDisallowPage and com.adobe.acs.commons.wcm.impl.RobotsServletTest#testDisallowPathAndAllowPage for use cases.