Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2830 - Dynamic Deck Dynamo rendering fix #2835

Merged

Conversation

davidjgonzalez
Copy link
Contributor

Allows a generic list to have no jcr:content/list without throwing NPE's as this is the initial state. A GL with no jcr:content/list is considered empty.

… breaking when the Dynamic Deck Dynamo has no items in its generic list page
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #2835 (62cf00e) into master (02a084a) will increase coverage by 0.00%.
The diff coverage is 94.44%.

@@            Coverage Diff            @@
##             master    #2835   +/-   ##
=========================================
  Coverage     53.89%   53.90%           
- Complexity     5574     5575    +1     
=========================================
  Files           753      753           
  Lines         30607    30609    +2     
  Branches       3964     3964           
=========================================
+ Hits          16497    16500    +3     
  Misses        12565    12565           
+ Partials       1545     1544    -1     
Impacted Files Coverage Δ
...acs/commons/genericlists/impl/GenericListImpl.java 74.50% <94.11%> (+1.59%) ⬆️
...s/genericlists/impl/GenericListAdapterFactory.java 63.63% <100.00%> (+5.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a084a...62cf00e. Read the comment docs.

@davidjgonzalez davidjgonzalez added this to the 5.3.2 milestone May 2, 2022
@davidjgonzalez davidjgonzalez requested review from kwin and badvision June 22, 2022 14:19
Copy link
Contributor

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidjgonzalez davidjgonzalez merged commit 91c2f26 into Adobe-Consulting-Services:master Jun 22, 2022
@davidjgonzalez davidjgonzalez deleted the fix/2830 branch June 22, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants