Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2808 Sorting numerical or Integer tags in ascending order in AEM #2814

Conversation

YegorKozlov
Copy link
Contributor

Addresses #2808

The PR adds a "Numbers First" checkbox to the Sort Nodes tool
image

If checked then numbers will be sorted first followed by alphabetical values.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #2814 (ee04c53) into master (a055760) will increase coverage by 0.00%.
The diff coverage is 60.41%.

@@            Coverage Diff            @@
##             master    #2814   +/-   ##
=========================================
  Coverage     53.81%   53.82%           
- Complexity     5539     5546    +7     
=========================================
  Files           753      753           
  Lines         30476    30516   +40     
  Branches       3938     3946    +8     
=========================================
+ Hits          16400    16424   +24     
- Misses        12546    12559   +13     
- Partials       1530     1533    +3     
Impacted Files Coverage Δ
.../adobe/acs/commons/sorter/impl/NodeNameSorter.java 46.87% <40.90%> (-24.56%) ⬇️
...adobe/acs/commons/sorter/impl/NodeTitleSorter.java 72.50% <76.92%> (+16.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a055760...ee04c53. Read the comment docs.

@davidjgonzalez
Copy link
Contributor

LGTM! I will update changelog for you! Thanks @YegorKozlov

@davidjgonzalez davidjgonzalez self-requested a review April 8, 2022 20:28
@davidjgonzalez davidjgonzalez merged commit b93a4f2 into Adobe-Consulting-Services:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants