Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #2658 by removing implementation of requestpathinfo #2732

Conversation

froggin
Copy link
Contributor

@froggin froggin commented Oct 22, 2021

No description provided.

@froggin froggin changed the title Resolved #2658 by removing implementation of requestpathinfo Resolves #2658 by removing implementation of requestpathinfo Oct 22, 2021
@@ -13,6 +13,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com)

### Fixed

- #2658 - Fixed issue where implementing RequestPathInfo was being caught by CQRules:CQBP-84gi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- #2658 - Fixed issue where implementing RequestPathInfo was being caught by CQRules:CQBP-84gi
- #2658 - Fixed issue where implementing RequestPathInfo was being caught by CQRules:CQBP-84

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #2732 (cfd3dd4) into master (7710498) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2732   +/-   ##
=========================================
  Coverage     52.38%   52.39%           
+ Complexity     5359     5358    -1     
=========================================
  Files           755      755           
  Lines         30310    30282   -28     
  Branches       3923     3915    -8     
=========================================
- Hits          15879    15867   -12     
+ Misses        12956    12941   -15     
+ Partials       1475     1474    -1     
Impacted Files Coverage Δ
...synth/impl/SynthesizedSlingHttpServletRequest.java 0.00% <0.00%> (ø)
...s/wcm/vanity/impl/ExtensionlessRequestWrapper.java 100.00% <ø> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7710498...cfd3dd4. Read the comment docs.

Copy link
Contributor Author

@froggin froggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kwin can this PR be cancelled please? I've made a new PR for this issue.

@kwin kwin closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants