Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CodeClimate issues #2466

Conversation

teropikala
Copy link
Contributor

Changes to fix about 50 (out of 70) reported CodeClimate issues.

I didn't want to include any changes to actual behaviour which should help reviewing changes.

@teropikala
Copy link
Contributor Author

For some reason Github lists earlier commits that are already merged to master.

@coveralls
Copy link

coveralls commented Nov 5, 2020

Pull Request Test Coverage Report for Build 6171

  • 10 of 22 (45.45%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 55.553%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bundle/src/main/java/com/adobe/acs/commons/workflow/bulk/execution/impl/TransientWorkflowUtil.java 0 1 0.0%
bundle/src/main/java/com/adobe/acs/commons/workflow/process/impl/CopyPropertiesProcess.java 0 1 0.0%
bundle/src/main/java/com/adobe/acs/commons/indesign/dynamicdeckdynamo/models/CollectionSelectComponent.java 0 3 0.0%
bundle/src/main/java/com/adobe/acs/commons/indesign/dynamicdeckdynamo/services/impl/XMLGeneratorServiceImpl.java 0 3 0.0%
bundle/src/main/java/com/adobe/acs/commons/indesign/dynamicdeckdynamo/models/GenericListSelectComponent.java 0 4 0.0%
Totals Coverage Status
Change from base Build 6170: -0.005%
Covered Lines: 15907
Relevant Lines: 28634

💛 - Coveralls

@davidjgonzalez davidjgonzalez added this to the 4.9.2 milestone Nov 10, 2020
@davidjgonzalez davidjgonzalez merged commit 58052b8 into Adobe-Consulting-Services:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants