Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing libraries #2133

Conversation

joerghoh
Copy link
Contributor

@joerghoh joerghoh commented Dec 7, 2019

Update the testing libraries to their latest available versions. In preparation for migration to JUnit 5.

  • also update joda-time (version 2.9.1 comes with AEM 6.3 and 6.4)

@update-changelog
Copy link

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request.

@coveralls
Copy link

coveralls commented Dec 7, 2019

Pull Request Test Coverage Report for Build 5337

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.03%) to 55.88%

Files with Coverage Reduction New Missed Lines %
bundle/src/main/java/com/adobe/acs/commons/analysis/jcrchecksum/impl/ChecksumGeneratorImpl.java 1 96.35%
bundle/src/main/java/com/adobe/acs/commons/httpcache/config/impl/HttpCacheConfigImpl.java 1 93.98%
bundle/src/main/java/com/adobe/acs/commons/replication/status/impl/ReplicationStatusManagerImpl.java 3 84.29%
Totals Coverage Status
Change from base Build 5334: 0.03%
Covered Lines: 15157
Relevant Lines: 27124

💛 - Coveralls

@joerghoh
Copy link
Contributor Author

Let's wait until aem-mocks 2.7.2 is released; i had to disable a test because of WTES-48 (https://wcm-io.atlassian.net/browse/WTES-48)

@joerghoh
Copy link
Contributor Author

Ready for merging, please review :-)

badvision
badvision previously approved these changes Jan 8, 2020
Copy link
Contributor

@badvision badvision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidjgonzalez davidjgonzalez merged commit d89563b into Adobe-Consulting-Services:master Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants