Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ETag header must be enclosed in double quotes #2054

Merged
merged 2 commits into from
Sep 30, 2019
Merged

ETag header must be enclosed in double quotes #2054

merged 2 commits into from
Sep 30, 2019

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Sep 20, 2019

@coveralls
Copy link

coveralls commented Sep 20, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 5046

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.356%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bundle/src/main/java/com/adobe/acs/commons/etag/impl/EtagMessageDigestServletFilter.java 0 1 0.0%
Totals Coverage Status
Change from base Build 5044: 0.0%
Covered Lines: 14407
Relevant Lines: 26505
💛 - Coveralls

@kwin kwin merged commit dfb4dca into Adobe-Consulting-Services:master Sep 30, 2019
@Roman-Skripka Roman-Skripka mentioned this pull request Oct 25, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badvision badvision badvision approved these changes

@justinedelson justinedelson Awaiting requested review from justinedelson

@davidjgonzalez davidjgonzalez Awaiting requested review from davidjgonzalez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ETag header not properly delivered from the servlet (missing quotes)
3 participants
@kwin @coveralls @badvision