Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing /var/acs-commons filter.xml #2032

Merged
merged 4 commits into from
Sep 27, 2019

Conversation

geertsmichael
Copy link
Contributor

Fixing /var/acs-commons filter.xml (removed double rep:policy, moved /var/workflow filter, added on-deploy-scripts-status)

…/var/workflow filter, added on-deploy-scripts-status)
@update-changelog
Copy link

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request.

…/var/workflow filter, added on-deploy-scripts-status) - added to changelog
@coveralls
Copy link

coveralls commented Sep 1, 2019

Pull Request Test Coverage Report for Build 5035

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 54.346%

Totals Coverage Status
Change from base Build 5028: 0.0%
Covered Lines: 14386
Relevant Lines: 26471

💛 - Coveralls

kwin
kwin previously approved these changes Sep 3, 2019
@geertsmichael
Copy link
Contributor Author

Could you merge this Pull Request please? Thank you.

@HitmanInWis
Copy link
Contributor

FWIW I believe the issues here were caused by commit 65fafaa back in June - this breaks On-Deploy Scripts for new installs, so thanks for this PR.

CHANGELOG.md Show resolved Hide resolved
@kwin
Copy link
Contributor

kwin commented Sep 17, 2019

I came up with a new PR for this in #2045 . @geertsmichael Could you cross-check?

@badvision
Copy link
Contributor

Should I close this PR in favor of #2045? Thanks to all of you folks working on this problem, by the way!

@HitmanInWis
Copy link
Contributor

Let's hold off for just a bit. Seems #2045 is having some issues currently (I'll take a look tomorrow) - want to confirm that one is good (it covers this and other changes, but the other changes are what is currently holding it up) before closing this.

@badvision
Copy link
Contributor

Fantastic. Happy to wait, just didn't want you fine folks thinking I was ignoring you. :)

Copy link
Contributor

@HitmanInWis HitmanInWis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests out successful

  • Adds ACL to /var/workflow/instances (additive to default AEM)
  • Adds missing /var/acs-commons/on-deploy-script-status files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants