-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing /var/acs-commons filter.xml #2032
Fixing /var/acs-commons filter.xml #2032
Conversation
…/var/workflow filter, added on-deploy-scripts-status)
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request. |
…/var/workflow filter, added on-deploy-scripts-status) - added to changelog
Pull Request Test Coverage Report for Build 5035
💛 - Coveralls |
Could you merge this Pull Request please? Thank you. |
FWIW I believe the issues here were caused by commit 65fafaa back in June - this breaks On-Deploy Scripts for new installs, so thanks for this PR. |
I came up with a new PR for this in #2045 . @geertsmichael Could you cross-check? |
Should I close this PR in favor of #2045? Thanks to all of you folks working on this problem, by the way! |
Let's hold off for just a bit. Seems #2045 is having some issues currently (I'll take a look tomorrow) - want to confirm that one is good (it covers this and other changes, but the other changes are what is currently holding it up) before closing this. |
Fantastic. Happy to wait, just didn't want you fine folks thinking I was ignoring you. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests out successful
- Adds ACL to /var/workflow/instances (additive to default AEM)
- Adds missing /var/acs-commons/on-deploy-script-status files
Fixing /var/acs-commons filter.xml (removed double rep:policy, moved /var/workflow filter, added on-deploy-scripts-status)